docs(lapis-docs): add documentation for interaction between 'maybe' and 'not'#1591
Merged
docs(lapis-docs): add documentation for interaction between 'maybe' and 'not'#1591
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds clarification to LAPIS documentation about how ambiguous symbols interact with negation, addressing confusion raised in issue #1554 (e.g., why NOT A134C/!A134C can match sequences with ambiguous/unknown bases at that position).
Changes:
- Extend the “Ambiguous symbols” concept doc with a new section explaining
MAYBEvs negation. - Provide a small example demonstrating the difference between
!3Gand!MAYBE(3G).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Fabian Engelniederhammer <92720311+fengelniederhammer@users.noreply.github.com>
fengelniederhammer
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1554
PR Checklist
All necessary changes are explained in thellms.txt.The implemented feature is covered by an appropriate test.